refator code

ulysseskao

2016-05-03 410dc2d04dbecf019129cd8cd65a3be2c62b4d0c

 CCSTrace/CCS/Function/InitialEventData.cs

@@ -9,12 +9,12 @@
    {

        private static readonly Logger Logger = LogManager.GetCurrentClassLogger();



        private string _mAcceptNum = "";

        private int _mCaseId = 0;

        private string _acceptNum = "";

        private int _caseId = 0;

        private int _mYear = 0;

        private bool _mChangeYear = false;

        private string _mNowYear = string.Empty;

        private readonly string _mAcceptTime = "";

        private bool _isChangeYear = false;

        private string _nowYear = string.Empty;

        private readonly string _acceptTime = "";

        private readonly OracleConnection _connectionTpc;



        //New CaseID and New AcceptNum must be seen by others,so it need not controled by transaction

@@ -32,10 +32,10 @@
            {

                if (reader.Read())

                {

                    _mAcceptNum = reader["ACCEPTNUM"].ToString();

                    _mCaseId = Convert.ToInt32(reader["CASEID"].ToString());

                    _acceptNum = reader["ACCEPTNUM"].ToString();

                    _caseId = Convert.ToInt32(reader["CASEID"].ToString());

                    _mYear = Convert.ToInt32(reader["YEAR"].ToString());

                    _mAcceptTime = reader["ACCEPTTIME"].ToString();

                    _acceptTime = reader["ACCEPTTIME"].ToString();

                }

                else

                {

@@ -46,7 +46,6 @@
            catch (Exception e)

            {

                Logger.Error(e, "Problems occur when Initializing EventData: " + e.Message);

                Console.WriteLine(e.StackTrace);

                return;

            }

            finally

@@ -57,7 +56,7 @@


            CheckAcceptNum();



            while (!UpdateDataBase(_mChangeYear))

            while (!UpdateDataBase(_isChangeYear))

            {

                RegetNumber();

                CheckAcceptNum();

@@ -66,12 +65,12 @@


        public int GetNewCaseId()

        {

            return _mCaseId;

            return _caseId;

        }



        public string GetNewAcceptNum()

        {

            return _mAcceptNum;

            return _acceptNum;

        }



        private bool UpdateDataBase(bool mChangeYear)

@@ -80,11 +79,11 @@
            bool mResult = false;



            if (mChangeYear)

                sqlStmt = "UPDATE EOS.EVENTNUM SET ACCEPTNUM = '" + (Convert.ToInt32(_mAcceptNum) + 1).ToString() + "',CASEID = "

                        + (_mCaseId + 1) + ",YEAR = " + _mNowYear + " WHERE CASEID = " + _mCaseId;

                sqlStmt = "UPDATE EOS.EVENTNUM SET ACCEPTNUM = '" + (Convert.ToInt32(_acceptNum) + 1) + "',CASEID = "

                        + (_caseId + 1) + ",YEAR = " + _nowYear + " WHERE CASEID = " + _caseId;

            else

                sqlStmt = "UPDATE EOS.EVENTNUM SET ACCEPTNUM = '" + (Convert.ToInt32(_mAcceptNum) + 1).ToString() + "',CASEID = "

                        + (_mCaseId + 1) + " WHERE CASEID = " + _mCaseId + " AND ACCEPTNUM = '" + _mAcceptNum + "'";

                sqlStmt = "UPDATE EOS.EVENTNUM SET ACCEPTNUM = '" + (Convert.ToInt32(_acceptNum) + 1) + "',CASEID = "

                        + (_caseId + 1) + " WHERE CASEID = " + _caseId + " AND ACCEPTNUM = '" + _acceptNum + "'";



            OracleCommand command = new OracleCommand(sqlStmt, _connectionTpc);



@@ -108,9 +107,9 @@


        private void CheckAcceptNum()

        {

            int nowYear = Convert.ToInt32(_mAcceptTime.Substring(0, 4)) - 1911;

            int nowMonth = Convert.ToInt32(_mAcceptTime.Substring(5, 2));

            string tmp = _mAcceptNum;

            int nowYear = Convert.ToInt32(_acceptTime.Substring(0, 4)) - 1911;

            int nowMonth = Convert.ToInt32(_acceptTime.Substring(5, 2));

            string tmp = _acceptNum;



            if (Convert.ToInt32(tmp.Substring(0, 3)) == nowYear)

            {

@@ -118,19 +117,19 @@
                {

                    // 新月份

                    if (nowMonth < 10)

                        _mAcceptNum = nowYear.ToString() + "0" + nowMonth.ToString() + "0001";

                        _acceptNum = nowYear + "0" + nowMonth + "0001";

                    else

                        _mAcceptNum = nowYear.ToString() + nowMonth.ToString() + "0001";

                        _acceptNum = nowYear + nowMonth.ToString() + "0001";

                }

            }

            else

            {

                _mAcceptNum = nowYear.ToString() + "010001"; // 新年度

                _mNowYear = nowYear.ToString();

                _mChangeYear = true;

                _acceptNum = nowYear + "010001"; // 新年度

                _nowYear = nowYear.ToString();

                _isChangeYear = true;

            }



            if (!_mChangeYear)

            if (!_isChangeYear)

            {

            }

        }

@@ -145,15 +144,14 @@
            {

                if (reader.Read())

                {

                    _mAcceptNum = reader["ACCEPTNUM"].ToString();

                    _mCaseId = Convert.ToInt32(reader["CASEID"].ToString());

                    _acceptNum = reader["ACCEPTNUM"].ToString();

                    _caseId = Convert.ToInt32(reader["CASEID"].ToString());

                    _mYear = Convert.ToInt32(reader["YEAR"].ToString());

                }

            }

            catch (Exception e)

            {

                Console.WriteLine(e.Message);

                Console.WriteLine(e.StackTrace);

                Logger.Error(e, e.Message);

            }

            finally

            {