From 410dc2d04dbecf019129cd8cd65a3be2c62b4d0c Mon Sep 17 00:00:00 2001
From: ulysseskao <ulysseskao@gmail.com>
Date: Tue, 03 May 2016 18:36:41 +0800
Subject: [PATCH] refator code

---
 CCSTrace/CCS/Object/Dept_Contrast.cs |   19 +++++++++----------
 1 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/CCSTrace/CCS/Object/Dept_Contrast.cs b/CCSTrace/CCS/Object/Dept_Contrast.cs
index ecf4ac1..af2a35e 100644
--- a/CCSTrace/CCS/Object/Dept_Contrast.cs
+++ b/CCSTrace/CCS/Object/Dept_Contrast.cs
@@ -37,9 +37,9 @@
                     }
                     else
                     {// 一對多(需作比對)
-                        long minMeter = Convert.ToInt64(tmpData[3].ToString());
-                        long maxMeter = Convert.ToInt64(tmpData[2].ToString());
-                        long custMeter = Convert.ToInt64(mMeter);
+                        var minMeter = Convert.ToInt64(tmpData[3].ToString());
+                        var maxMeter = Convert.ToInt64(tmpData[2].ToString());
+                        var custMeter = Convert.ToInt64(mMeter);
 
                         if ((custMeter > minMeter) && (custMeter < maxMeter))
                         {
@@ -51,7 +51,7 @@
             }
             catch (Exception ex)
             {
-                Console.WriteLine(ex.Message);
+                Logger.Warn(ex, ex.Message);
             }
             return result;
         }
@@ -91,7 +91,7 @@
             }
             catch (Exception ex)
             {
-                Console.WriteLine(ex.Message);
+                Logger.Warn(ex, ex.Message);
             }
 
             return result;
@@ -99,10 +99,9 @@
 
         private void Initial(OracleConnection connectionTpc, OracleTransaction trx)
         {
-            string sqlStmt;
             _mTotalData = new ArrayList();
 
-            sqlStmt = "SELECT SC_CODE,DEPT_CODE,MAX_METER,MIN_METER FROM CCS.DEPT_CONTRAST";
+            var sqlStmt = "SELECT SC_CODE,DEPT_CODE,MAX_METER,MIN_METER FROM CCS.DEPT_CONTRAST";
             OracleCommand command = new OracleCommand(sqlStmt, connectionTpc, trx);
             OracleDataReader reader = command.ExecuteReader();
 
@@ -122,12 +121,12 @@
             }
             catch (Exception e)
             {
-                Console.WriteLine(e.StackTrace);
+                Logger.Warn(e, e.Message);
             }
             finally
             {
-                reader.Close();
-                command.Dispose();
+                reader?.Close();
+                command?.Dispose();
             }
         }
     }

--
Gitblit v0.0.0-SNAPSHOT