From 410dc2d04dbecf019129cd8cd65a3be2c62b4d0c Mon Sep 17 00:00:00 2001 From: ulysseskao <ulysseskao@gmail.com> Date: Tue, 03 May 2016 18:36:41 +0800 Subject: [PATCH] refator code --- CCSTrace/CCS/Object/LocateEquipment.cs | 91 ++++++++++++++++----------------------------- 1 files changed, 32 insertions(+), 59 deletions(-) diff --git a/CCSTrace/CCS/Object/LocateEquipment.cs b/CCSTrace/CCS/Object/LocateEquipment.cs index 6f798e7..ae38d64 100644 --- a/CCSTrace/CCS/Object/LocateEquipment.cs +++ b/CCSTrace/CCS/Object/LocateEquipment.cs @@ -18,14 +18,14 @@ public LocateEquipment(int mCaseId, bool hasData, OracleConnection conn, OracleTransaction transaction) { - string sqlStmt; OracleCommand command = null; OracleDataReader reader = null; - SetCaseId(mCaseId); + CaseId = mCaseId; try { + string sqlStmt; if (hasData) { sqlStmt = "SELECT DSUFID,FSC,UFID,FDR,TPCLID FROM EOS.EVENTRECORD_EX WHERE CASEID = " + mCaseId; @@ -35,11 +35,11 @@ if (reader.Read()) { - SetDsufid(Convert.ToInt32(reader["DSUFID"].ToString())); - SetFsc(Convert.ToInt32(reader["FSC"].ToString())); - SetUfid(Convert.ToInt32(reader["UFID"].ToString())); - SetFdr(reader["FDR"].ToString()); - SetTpclid(reader["TPCLID"].ToString()); + DsUfid =Convert.ToInt32(reader["DSUFID"].ToString()); + Fsc = Convert.ToInt32(reader["FSC"].ToString()); + Ufid = Convert.ToInt32(reader["UFID"].ToString()); + Fdr = reader["FDR"].ToString(); + Tpclid = reader["TPCLID"].ToString(); } } else @@ -50,87 +50,60 @@ reader = command.ExecuteReader(); if (reader.Read()) - SetDsufid(Convert.ToInt32(reader["UFID"].ToString())); + DsUfid = Convert.ToInt32(reader["UFID"].ToString()); } } catch (Exception e) { - Console.WriteLine(e.Message); - Console.WriteLine(e.StackTrace); + Logger.Warn(e, e.Message); } finally { - reader.Close(); - command.Dispose(); + reader?.Close(); + command?.Dispose(); } } - public int GetCaseId() + public int CaseId { - return _caseId; + get { return _caseId; } + set { _caseId = value; } } - public void SetCaseId(int mCaseId) + public int DsUfid { - _caseId = mCaseId; + get { return _dsUfid; } + set { _dsUfid = value; } } - public int GetDsufid() + public int Fsc { - return _dsUfid; + get { return _fsc; } + set { _fsc = value; } } - public void SetDsufid(int mDsUfid) + public int Ufid { - _dsUfid = mDsUfid; + get { return _ufid; } + set { _ufid = value; } } - public int GetFsc() + public string Fdr { - return _fsc; + get { return _fdr; } + set { _fdr = value; } } - public void SetFsc(int mFsc) + public string Tpclid { - _fsc = mFsc; + get { return _tpclid; } + set { _tpclid = value; } } - public int GetUfid() + public string GetInsertSqlStmt() { - return _ufid; - } - - public void SetUfid(int mUfid) - { - _ufid = mUfid; - } - - public string GetFdr() - { - return _fdr; - } - - public void SetFdr(string mFdr) - { - _fdr = mFdr; - } - - public string GetTpclid() - { - return _tpclid; - } - - public void SetTpclid(string mTpclid) - { - _tpclid = mTpclid; - } - - public string GetSqlStmt() - { - string sqlStmt; - - sqlStmt = "INSERT INTO EOS.EVENTRECORD_EX (CASEID,DSUFID,FSC,UFID,TPCLID,FDR) VALUES(" + GetCaseId() + "," + GetDsufid() + "," + GetFsc() - + "," + GetUfid() + ",'" + GetTpclid() + "','" + GetFdr() + "')"; + var sqlStmt = "INSERT INTO EOS.EVENTRECORD_EX (CASEID,DSUFID,FSC,UFID,TPCLID,FDR) VALUES(" + CaseId + "," + DsUfid + "," + Fsc + + "," + Ufid + ",'" + Tpclid + "','" + Fdr + "')"; return sqlStmt; } -- Gitblit v0.0.0-SNAPSHOT